Opened on 08/24/2017 at 03:09:08 PM

Closed on 08/31/2017 at 04:19:08 PM

Last modified on 10/05/2017 at 10:27:22 PM

#5567 closed change (fixed)

Disable mercurial-setup permanently

Reported by: jwangenheim Assignee: jwangenheim
Priority: P4 Milestone: Adblock-Browser-for-Android-1.3.0
Module: Adblock-Browser-for-Android Keywords:
Cc: fhd Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29527555/

Description (last modified by jwangenheim)

Background

We are currently asked to run ./mach mercurial-setup` once a month, but we actually don't need anything of what it does. For this reason we want to disable this check permanently.

What to change

Seems as if we are not the only ones that are annoyed by mercurial-setup. There is already a variable called 'I_PREFER_A_SUBOPTIMAL_MERCURIAL_EXPERIENCE', we just have to add to the build environment.

Attachments (0)

Change History (9)

comment:1 Changed on 08/25/2017 at 07:49:47 AM by jwangenheim

  • Cc fhd added
  • Description modified (diff)

comment:2 Changed on 08/25/2017 at 08:06:30 AM by jwangenheim

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 08/31/2017 at 04:09:17 PM by abpbot

A commit referencing this issue has landed:
Issue 5567 - Disable mercurial-setup permanently

comment:4 Changed on 08/31/2017 at 04:19:08 PM by jwangenheim

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 08/31/2017 at 05:06:19 PM by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next

comment:6 Changed on 08/31/2017 at 05:06:45 PM by diegocarloslima

  • Platform changed from Android to Adblock Browser for Android

comment:7 Changed on 09/28/2017 at 03:24:41 PM by traynard

If this item is testable, please provide some testing information/instructions

comment:8 Changed on 10/05/2017 at 10:05:49 PM by diegocarloslima

This is also a build time issue. It has passed 5 weeks since the commit was pushed and so far I didn't get any message to configure Mercurial. So it seems to be working fine.

comment:9 Changed on 10/05/2017 at 10:27:22 PM by traynard

  • Verified working set

Thanks diego, marking as verified working.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from jwangenheim.
 
Note: See TracTickets for help on using tickets.