Opened on 08/25/2017 at 12:30:53 PM
Closed on 08/25/2017 at 01:13:27 PM
Last modified on 09/14/2017 at 12:48:58 PM
#5577 closed change (fixed)
let build.py allow non-numerical build numbers for gecko-webext
| Reported by: | tlucas | Assignee: | |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | sebastian, trev | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
We want to switch our beta channel on AMO to the webext builds. Therefore the version numbers must be in the format like *.*.*.*-beta.
What to change
Change build.py to allow non-numerical build numbers for gecko-webext builds, the way it is already allowed for legacy gecko builds.
Attachments (0)
Change History (5)
comment:1 Changed on 08/25/2017 at 12:35:03 PM by sebastian
- Description modified (diff)
- Priority changed from Unknown to P1
- Ready set
comment:2 Changed on 08/25/2017 at 01:12:12 PM by tlucas
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 08/25/2017 at 01:13:08 PM by abpbot
comment:4 Changed on 08/25/2017 at 01:13:27 PM by tlucas
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 09/14/2017 at 12:48:58 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Building with non-numerical characters in the file/build name works as expected.
adblockpluschrome / 1846:44197859df84
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5577 - allow non-numerical build-nums for gecko-webext