Opened on 08/25/2017 at 12:44:22 PM
Closed on 08/25/2017 at 01:29:23 PM
Last modified on 09/14/2017 at 12:48:33 PM
#5578 closed change (fixed)
Update buildtools dependency to hg:0234926280f1
| Reported by: | tlucas | Assignee: | |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-1.13.4-for-Chrome-Opera |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, trev | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by tlucas)
What to change
Update the buildtools dependency in adblockpluschrome to:
| hg | git |
| 0234926280f1 | 48bb35a |
Included changes
| Ticket | Summary | Component |
|---|---|---|
| #5577 | let build.py allow non-numerical build numbers for gecko-webext | Automation |
Hints for testers
You should be able to create gecko-webext builds with non-numerical buildnums, e.g.
./build.py -t gecko-webext build -b 1889-beta -> adblockplusfirefox-2.9.0.1889-beta.xpi
Attachments (0)
Change History (10)
comment:3 Changed on 08/25/2017 at 01:15:16 PM by tlucas
- Cc sebastian trev added
- Description modified (diff)
comment:4 Changed on 08/25/2017 at 01:17:53 PM by tlucas
- Summary changed from Update buildtools dependency to hg: to Update buildtools dependency to hg:0234926280f1
comment:5 Changed on 08/25/2017 at 01:20:01 PM by sebastian
- Priority changed from Unknown to P1
- Ready set
comment:6 Changed on 08/25/2017 at 01:21:10 PM by tlucas
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 08/25/2017 at 01:28:47 PM by abpbot
comment:8 Changed on 08/25/2017 at 01:29:23 PM by tlucas
- Resolution set to fixed
- Status changed from reviewing to closed
comment:9 Changed on 09/05/2017 at 10:18:35 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-next
comment:10 Changed on 09/14/2017 at 12:48:33 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Building with non-numerical characters in the file/build name works as expected.
adblockpluschrome / 1846:44197859df84
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5578 - Update buildtools dependency to hg:0234926280f1