Opened on 08/25/2017 at 09:01:57 PM
Closed on 08/28/2017 at 09:32:52 PM
Last modified on 10/02/2017 at 11:57:54 PM
#5580 closed defect (fixed)
Multilocale build fails due to missing search engine plugin file
| Reported by: | diegocarloslima | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-Android-1.3.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description
Mozilla has introduced the concept of hidden search plugins, which shows in the list.txt file but they don't have a .xml file. With that, our abb-transform-locales step fails when it tries to find the .xml file for google:hidden. We need to skip those entries.
Attachments (0)
Change History (6)
comment:1 Changed on 08/25/2017 at 09:56:44 PM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 08/28/2017 at 09:18:17 PM by abpbot
comment:3 Changed on 08/28/2017 at 09:32:52 PM by diegocarloslima
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 09/28/2017 at 03:20:08 PM by traynard
If this item is testable, please provide some testing information/instructions
comment:5 Changed on 09/28/2017 at 08:22:26 PM by diegocarloslima
@traynard: This is a build time issue. I believe that the best way to test it is by building the ABB project and checking if it performs successfully. Since I was able to build the project in order to generate the release candidate .apk, I think that we might consider this as verified working.
comment:6 Changed on 10/02/2017 at 11:57:54 PM by traynard
- Verified working set
A commit referencing this issue has landed:
Issue 5580 - Multilocale build fails due to missing search engine plugin file