Opened on 08/25/2017 at 09:14:54 PM
Closed on 10/05/2017 at 03:40:20 PM
Last modified on 10/11/2017 at 09:45:01 PM
#5581 closed defect (fixed)
Multilocale build fails to copy gecko-unsigned-unaligned.apk
| Reported by: | diegocarloslima | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-Android-1.3.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): |
https://codereview.adblockplus.org/29527871/ |
||
Description (last modified by diegocarloslima)
Mozilla has changed the name of the generated unsigned .apk artefact from gecko-unsigned-unaligned.apk to fennec-[APP_VERSION].multi.android-[ARCHITECTURE]-unsigned-unaligned.apk. Also, the architecture part for x86 builds has changed to i386. We need to update our build.py script in order to take into consideration that change and properly copy/rename the unsigned .apk file to adblockbrowser-[APP_VERSION]-[BUILD_ID]-[ARCHITECTURE].apk.
Attachments (0)
Change History (11)
comment:1 Changed on 08/25/2017 at 10:22:19 PM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 09/20/2017 at 04:48:28 PM by abpbot
comment:3 Changed on 09/20/2017 at 05:23:36 PM by diegocarloslima
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 09/28/2017 at 03:20:28 PM by traynard
If this item is testable, please provide some testing information/instructions
comment:5 Changed on 09/28/2017 at 08:23:47 PM by diegocarloslima
@traynard: This is a build time issue. I believe that the best way to test it is by building the ABB project and checking if it performs successfully. Since I was able to build the project in order to generate the release candidate .apk, I think that we might consider this as verified working.
comment:7 Changed on 09/29/2017 at 06:56:54 PM by diegocarloslima
- Resolution fixed deleted
- Status changed from closed to reopened
comment:8 Changed on 09/29/2017 at 06:58:08 PM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from reopened to reviewing
comment:9 Changed on 10/05/2017 at 03:39:55 PM by abpbot
A commit referencing this issue has landed:
Issue 5581 - Multilocale build fails to copy gecko-unsigned-unaligned.apk
comment:10 Changed on 10/05/2017 at 03:40:20 PM by diegocarloslima
- Resolution set to fixed
- Status changed from reviewing to closed
comment:11 Changed on 10/11/2017 at 09:45:01 PM by traynard
- Verified working set
Verified working per diego's comment.
A commit referencing this issue has landed:
Issue 5581 - Multilocale build fails to copy gecko-unsigned-unaligned.apk