Opened on 08/25/2017 at 10:52:10 PM
Closed on 08/29/2017 at 04:14:48 PM
Last modified on 09/12/2017 at 08:57:25 AM
#5582 closed change (fixed)
Workaround Edge bug in tabs.query
| Reported by: | oleksandr | Assignee: | oleksandr |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.13.4-for-Chrome-Opera |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, Ross | Blocked By: | |
| Blocking: | Platform: | Edge | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
Edge does not support querying tabs with URLs that have ms-browser-extension:// protocol. See https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8094141/ and https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8604703/. We rely on that to find existing options page.
What to change
Either remove the code that tries to detect already opened Options page, or workaround the bug by searching using page title instead.
Attachments (0)
Change History (8)
comment:1 Changed on 08/25/2017 at 11:03:47 PM by oleksandr
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 08/29/2017 at 12:58:18 PM by sebastian
- Priority changed from Unknown to P2
- Ready set
comment:3 Changed on 08/29/2017 at 04:13:40 PM by abpbot
comment:4 Changed on 08/29/2017 at 04:14:48 PM by oleksandr
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 09/05/2017 at 10:18:35 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-next
comment:6 Changed on 09/11/2017 at 05:39:06 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Options page opens as expected and existing options tab is focused if already open.
ABP 0.9.11.1842
Edge 40 / Windows 10
comment:7 Changed on 09/11/2017 at 06:59:13 PM by sebastian
- Cc Ross added
Please make sure to not only test on the browser the change is supposed to have any effect on, but also verify that the change doesn't break anything on other platforms (Chrome in particular).
comment:8 Changed on 09/12/2017 at 08:57:25 AM by Ross
Double checked Chrome/Opera behavior.
ABP 0.13.3.1838
Chrome 49 / 60 Windows 7
Opera 36 / 46 / Windows 7
A commit referencing this issue has landed:
Issue 5582 - Workaround Edge bug in tabs.query