Opened on 08/28/2017 at 04:42:59 PM

Closed on 08/29/2017 at 09:18:24 AM

#5586 closed change (fixed)

Use SVG instead of PNG for toggle image in mobile options page

Reported by: greiner Assignee: greiner
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By: #5384
Blocking: #5587 Platform: Firefox Mobile
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29529779/

Description

Background

In #5384 we introduced we introduced a dedicated mobile version of our new options page for Adblock Plus for Firefox Mobile. However, a recent spec draft changed the file format for the toggle button image.

What to change

Use toggle.svg instead of toggle.png as specified in the ​ABP Firefox mobile: Options page Specification (draft).

Attachments (0)

Change History (5)

comment:1 Changed on 08/28/2017 at 04:43:29 PM by greiner

  • Blocking 5587 added

comment:2 Changed on 08/28/2017 at 05:26:38 PM by greiner

  • Owner set to greiner

comment:3 Changed on 08/28/2017 at 06:04:14 PM by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 08/29/2017 at 09:07:03 AM by abpbot

A commit referencing this issue has landed:
Issue 5586 - Replaced toggle.png with toggle.svg

comment:5 Changed on 08/29/2017 at 09:18:24 AM by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from greiner.
 
Note: See TracTickets for help on using tickets.