Opened on 08/31/2017 at 10:36:35 AM

Closed on 08/31/2017 at 01:32:11 PM

#5603 closed change (fixed)

[emscripten] Support references in parameters of exported functions

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: #4122 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29532626/

Description

Background

For parameters of functions exported to JavaScript, we currently only support passing objects by pointer. We should support passing by reference as well, so that the parameter is guaranteed to be non-null.

What to change

  • Change bindings code to support reference types.
  • Make sure that passing objects by reference generates an additional check so that passing in null will throw.
  • Convert pointer parameters to references where appropriate.

Attachments (0)

Change History (5)

comment:1 Changed on 08/31/2017 at 10:37:12 AM by trev

  • Summary changed from [emscripten] to [emscripten] Support references in parameters of exported functions

comment:2 Changed on 08/31/2017 at 12:26:35 PM by trev

  • Owner set to trev

comment:3 Changed on 08/31/2017 at 12:37:51 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 08/31/2017 at 01:30:42 PM by abpbot

A commit referencing this issue has landed:
​Issue 5603 - Support references in parameters of exported functions

comment:5 Changed on 08/31/2017 at 01:32:11 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.