Opened on 08/31/2017 at 10:44:03 AM
Closed on 08/31/2017 at 01:32:16 PM
#5604 closed change (fixed)
[emscripten] Put BINDINGS_EXPORTED after the return type consistently
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #4122 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
Currently, we sometimes have BINDINGS_EXPORTED before the function return type, sometimes after it.
What to change
Put BINDINGS_EXPORTED after the return type consistently, following the convention from EMSCRIPTEN_KEEPALIVE.
Attachments (0)
Change History (5)
comment:1 Changed on 08/31/2017 at 10:45:07 AM by trev
- Blocking 4122 added
comment:2 Changed on 08/31/2017 at 11:59:19 AM by trev
- Owner set to trev
comment:3 Changed on 08/31/2017 at 12:01:37 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 08/31/2017 at 01:30:43 PM by abpbot
comment:5 Changed on 08/31/2017 at 01:32:16 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5604 - Make sure to put EMSCRIPTEN_BINDINGS after the type consistently