Opened on 09/06/2017 at 12:31:14 PM

Closed on 09/09/2019 at 02:48:07 PM

#5630 closed change (worksforme)

Marking newly added table items

Reported by: saroyanm Assignee:
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner, juliandoucette Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

After several design iterations we finally have a final version of the new options page (See #5158), but currently we only marking newly added Whitelisted domain, by moving it into the top of the list, while according to the specification and style guide Newly added filter lists and languages are also having highlight.

What to change

Add highlight to the newly added filter list and languages as specified.

Attachments (0)

Change History (5)

comment:1 Changed on 09/06/2017 at 12:31:33 PM by saroyanm

  • Blocking 5158 added

comment:2 Changed on 09/20/2017 at 11:05:11 AM by saroyanm

  • Blocking 5158 removed

comment:3 follow-up: Changed on 02/13/2018 at 10:00:25 AM by agiammarchi

currently we only marking newly added Whitelisted domain, by moving it into the top of the list

is this a behaviour we've lost at some point? To me it looks like we just show filters based on alphabetic order. Mind clarifying if this ticket is still valid?

comment:4 in reply to: ↑ 3 Changed on 02/14/2018 at 02:23:35 PM by greiner

Replying to agiammarchi:

is this a behaviour we've lost at some point? To me it looks like we just show filters based on alphabetic order. Mind clarifying if this ticket is still valid?

We initialize filters in alphabetical order on page load. When you add a new filter we add it to the top of the list rather than inserting it accordingly (see options page spec).

comment:5 Changed on 09/09/2019 at 02:48:07 PM by greiner

  • Resolution set to worksforme
  • Status changed from new to closed

Closing this ticket because it's unclear whether this expectation still holds up with the current state of the spec.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
 
Note: See TracTickets for help on using tickets.