Opened on 09/06/2017 at 12:55:53 PM

Closed on 09/18/2017 at 10:28:19 AM

#5631 closed defect (fixed)

In more filters section filters that are disabled are being shown on first load

Reported by: saroyanm Assignee: saroyanm
Priority: P1 Milestone:
Module: User-Interface Keywords:
Cc: greiner, juliandoucette Blocked By:
Blocking: #5158 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29545663/

Description

Environment

Chrome v60

How to reproduce

  1. Run test server for Adblockplusui and/or navigate to github pages
  2. Open advanced tab ​Advanced tab
  3. Observe the "Adblock Warning Removal List" item
  4. Navigate to General tab
  5. Observe same item in "More filters" section

Observed behaviour

"Adblock Warning Removal List" is being disabled in the advanced tab and being shown on the General tab still.

Expected behaviour

"Adblock Warning Removal List" is not being shown in the general tab when it's disabled.

Attachments (0)

Change History (4)

comment:1 Changed on 09/15/2017 at 10:18:06 AM by saroyanm

  • Owner set to saroyanm

comment:2 Changed on 09/15/2017 at 04:38:25 PM by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 09/18/2017 at 10:27:05 AM by abpbot

A commit referencing this issue has landed:
​Issue 5631 - do not show disabled filters in more section

comment:4 Changed on 09/18/2017 at 10:28:19 AM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.