Opened on 09/12/2017 at 02:13:48 PM
Closed on 09/13/2017 at 02:31:29 PM
#5662 closed change (duplicate)
[emscripten] Create patterns.ini parser
Reported by: | sergz | Assignee: | |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Core | Keywords: | |
Cc: | trev | Blocked By: | |
Blocking: | #4122, #5137 | Platform: | Unknown / Cross platform |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Background
As a part of #5137 we should be able to parse patterns.ini.
What to change
In accordance with #5661 there should be PatternsIniParser which is aware about our INI format. Since the serialization of subscription properties is left in corresponding Subscription classes (#5661), there should be a static SubscriptionPtr Subscription::Parse(const SomeKeyValues&) method which can create an instance of corresponding Subscription class and set corresponding properties. In accordance with the current implementation of INIParser there should be either void Subscription::addFilter(Filter&) method adding a filter to the end of the subscription filter list or void Subscription::setFilters(Filters&&) method, both are not notifying. It could be helpful if they can be re-used by a parser of DownloadableSubscription (#5146).
Am I missing something or is this a duplicate of #4128?