Opened on 09/15/2017 at 12:26:07 AM

Closed on 09/19/2017 at 07:18:36 AM

#5688 closed change (fixed)

Reduce built frameworks to only arm64 architecture

Reported by: dzhang Assignee: dzhang
Priority: Unknown Milestone: Adblock-Plus-for-iOS-next
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: mario, tiago, ashephard, CraftyDeano Blocked By:
Blocking: Platform: iOS
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29538564/

Description

Background

A dynamic framework may contain unnecessary architectures. Rather than policing every build configuration, we can remove them before distribution because that is the point where an unneeded architecture slice will have the most impact.

This is an optimization to reduce the size of the release binary.

What to change

Remove any unneeded architectures in frameworks contained in a release archive.

Attachments (0)

Change History (2)

comment:1 Changed on 09/15/2017 at 01:18:16 AM by dzhang

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 09/19/2017 at 07:18:36 AM by dzhang

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from dzhang.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.