Opened on 09/15/2017 at 08:02:47 AM

Closed on 02/08/2018 at 04:07:21 PM

#5689 closed change (fixed)

Add rules for CSS declaration order to stylelint-config-eyeo

Reported by: ire Assignee: ire
Priority: P3 Milestone:
Module: Automation Keywords: goodfirstbug
Cc: saroyanm, greiner, martin, p.pastourmatzis, erick, fhd, juliandoucette Blocked By: #5109
Blocking: #6288 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29643562/

Description

Background

Our Coding Style states that "CSS rule declaration order should follow the WordPress CSS Coding Standards".

What to change

In #5109 we are creating a stylelint configuration for eyeo but the default stylelint rules no longer include declaration order.

Use a stylelint plugin (such as stylelint-order) to set a declaration order to our stylelint-config

Attachments (0)

Change History (7)

comment:1 Changed on 09/15/2017 at 08:03:38 AM by ire

  • Cc juliandoucette added

comment:2 Changed on 12/05/2017 at 04:06:13 PM by juliandoucette

  • Component changed from Websites to Automation
  • Keywords goodfirstbug added

comment:3 Changed on 12/14/2017 at 03:21:01 PM by ire

  • Owner set to ire
  • Priority changed from Unknown to P3
  • Ready set

comment:4 Changed on 12/18/2017 at 09:43:05 AM by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 01/22/2018 at 09:35:56 AM by kzar

  • Blocking 6288 added

comment:6 Changed on 02/08/2018 at 04:06:18 PM by abpbot

comment:7 Changed on 02/08/2018 at 04:07:21 PM by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ire.
 
Note: See TracTickets for help on using tickets.