Opened on 09/15/2017 at 06:21:29 PM
Closed on 09/25/2017 at 09:46:17 PM
#5701 closed defect (fixed)
Inconsistent forum link on new options page and missing DNT link
Reported by: | sebastian | Assignee: | saroyanm |
---|---|---|---|
Priority: | P1 | Milestone: | |
Module: | User-Interface | Keywords: | |
Cc: | wspee, greiner, saroyanm | Blocked By: | |
Blocking: | #5158 | Platform: | Unknown / Cross platform |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by saroyanm)
How to reproduce
- Run ./test_server.py from inside the adblockplusuirepository.
- Go to http://localhost:5000/new-options.html?platform=chromium#help
- Click "Go to Forum" link.
- Observe
- Go to http://localhost:5000/new-options.html#general
- Click on "Allow only nonintrusive ads that are privacy-friendly"
- Click on "Find out how to turn on DNT"
- Observe
Observed behaviour
- Step 4: It opens https://adblockplus.org/redirect?link=reporter_other_link in a new tab which redirects to https://adblockplus.org/forum/. That is a step back from the old options page which linked to the corresponding sub-forum.
- Step 8: Find out how to turn on DNT link is missing
Expected behaviour
- Step 4: The "Go to Forum" link should link to https://adblockplus.org/redirect?link=<application>_support&lang=<lang>, where <application> is the application from the info module, except info.platform == "chromium" && info.application != "opera" in which case it should be chrome (as we don't have separate sub-forums for all Chromium forks). See here. logic of the old options page.
- Step 8: Find out how to turn on DNT should behave as specified here
Attachments (0)
Change History (9)
comment:2 Changed on 09/18/2017 at 03:49:39 PM by wspee
@saroyanm
I think it was an oversight, see #78.
comment:3 Changed on 09/25/2017 at 01:32:25 PM by saroyanm
- Blocking 5158 added
- Priority changed from Unknown to P2
- Ready set
comment:4 Changed on 09/25/2017 at 03:41:11 PM by saroyanm
- Description modified (diff)
- Priority changed from P2 to P1
- Summary changed from Inconsistent forum link on new options page to Inconsistent forum link on new options page and missing DNT link
DNT link should behave similarly so I merged both issues, to tackle them here.
comment:6 Changed on 09/25/2017 at 03:42:45 PM by saroyanm
- Owner set to saroyanm
comment:7 Changed on 09/25/2017 at 04:00:20 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:8 Changed on 09/25/2017 at 09:44:55 PM by abpbot
A commit referencing this issue has landed:
Issue 5701 - fixed inconsistent forum links and missing DNT link
comment:9 Changed on 09/25/2017 at 09:46:17 PM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
I assume you mean the link in Help tab as I can't find one in the advanced tab.
@wspee do you remember if there was a reason why we decided to redirect to redirect to the forum, but not to the platform specific sub page ? If not, please let me know if you want me to create a bitbucket issue for this.