Opened on 09/19/2017 at 09:24:57 AM
Closed on 08/29/2019 at 05:43:52 PM
#5732 closed change (rejected)
[emscripten] Stop using i64 arithmetic
| Reported by: | trev | Assignee: | rjeschke |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Core | Keywords: | closed-in-favor-of-gitlab |
| Cc: | oleksandr | Blocked By: | |
| Blocking: | #4122 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
i64 arithmetic is very inefficient with Emscripten. However, we are currently using it when parsing or serializing timestamps.
What to change
Store timestamps as i32 numbers internally (seconds rather than milliseconds). For compatibility with the existing storage format, add three trailing zeros to timestamps when serializing. Also, ignore the last three digits when parsing timestamps. Use a new type for timestamps, so that the generated bindings code can automatically add * 1000 for the property getters and / 1000 for property setters.
Attachments (0)
Change History (4)
comment:1 Changed on 10/11/2017 at 01:03:57 PM by oleksandr
- Cc oleksandr added
comment:2 Changed on 11/13/2017 at 03:19:22 PM by rjeschke
- Owner set to rjeschke
comment:3 Changed on 12/14/2018 at 12:24:55 PM by hfiguiere
comment:4 Changed on 08/29/2019 at 05:43:52 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.
Note: See
TracTickets for help on using
tickets.
This is not a problem if we move to WebAssembly.
See issue #6312