Opened on 09/19/2017 at 09:38:19 AM

Closed on 09/27/2017 at 01:27:33 PM

Last modified on 09/27/2017 at 02:22:36 PM

#5733 closed defect (fixed)

Make unlocalized strings localizable

Reported by: mario Assignee:
Priority: P2 Milestone:
Module: Adblock-Browser-for-iOS Keywords: ABB2.0.1
Cc: Blocked By:
Blocking: Platform: Adblock Browser for iOS
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by mario)

Environment

ABB 2.0.0
iOS v*

How to reproduce

There are currently two strings which aren't localizable as they're hardcoded. These need to replaced by localizable strings:

String 1

  1. Switch the language of your device to another language other than English
  2. Start ABB
  3. Open the Tabs overview
  4. Observe the string Add New Tab

String 2

  1. Switch the language of your device to another language other than English
  2. Start ABB
  3. Open a new Tab
  4. On the Dashboard observe the string Tap and hold an item to modify it.

Observed behaviour

Despite the device not being in English, both strings are displayed in English

Expected behaviour

Both strings are displayed in the language the device is configured to

Attachments (0)

Change History (4)

comment:1 Changed on 09/19/2017 at 09:41:44 AM by mario

  • Keywords ABB2.0.1 added

comment:2 Changed on 09/27/2017 at 01:27:33 PM by jand

  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed on 09/27/2017 at 02:19:31 PM by mario

  • Description modified (diff)

comment:4 Changed on 09/27/2017 at 02:22:36 PM by mario

  • Description modified (diff)

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.