Opened on 09/19/2017 at 09:43:37 AM
Closed on 10/31/2017 at 01:57:58 PM
#5734 closed change (fixed)
Add utility classes to website-defaults
| Reported by: | ire | Assignee: | ire |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Websites | Keywords: | |
| Cc: | juliandoucette, wspee | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by ire)
Background
There are a few styles we want to be able to reuse across eyeo websites.
What to change
Create a _utilities.scss file and include at least:
- .sr-only: For elements we want to be visible to only screen readers
- .clearfix: For clearing floats
- .text-center (and related): For aligning text
See https://codereview.adblockplus.org/29516622/diff/29549725/static/scss/base/_utilities.scss?context=&column_width=80 for reference
Attachments (0)
Change History (6)
comment:3 Changed on 10/30/2017 at 04:04:50 PM by ire
- Owner set to ire
- Ready set
comment:4 Changed on 10/30/2017 at 04:04:56 PM by ire
- Priority changed from Unknown to P3
comment:5 Changed on 10/31/2017 at 01:57:39 PM by abpbot
comment:6 Changed on 10/31/2017 at 01:57:58 PM by ire
- Resolution set to fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5734 - Add utility classes to website-defaults