Start using promises in new options page

[saroyanm]

Background

We are making a lot of Async calls in the new options page using ​browser.runtime.sendMessage (Dont' mix with actual ​browser.runtime.sendMessage which return promise).
In order to make the code more modern and be able get use of Promises instead of regular Async calls we should update the Options Page accordingly, while all targeted browsers we plan to ship new options page support Promises.

What to change

Use Promises for Async calls in the desktop version of options page.

[saroyanm]

I'm not sure if the Priority is to low, do we want to ship this early rather than later ?

Sidenote: Ideally I think we would have adapted our message handler to use promises rather than wrapping each call individually ? Is there any reason we don't consider doing that ? So browser.runtime.sendMessage will return promise ?

[greiner]

Replying to saroyanm:

I'm not sure if the Priority is to low, do we want to ship this early rather than later ?

According to the definition of priorities, this should be given P3 because we definitely want this but it's not a priority.

Sidenote: Ideally I think we would have adapted our message handler to use promises rather than wrapping each call individually ? Is there any reason we don't consider doing that ? So browser.runtime.sendMessage will return promise ?

It's pretty much up to Platform which interfaces they want to provide us with. Let's not implement our own abstraction layer for the same APIs that Platform also uses. Otherwise we'd end up with a bunch of duplicated code.

[greiner]

Is this ticket still relevant or can we close it?

Because we've already started adopting promises in various places. Plus, not only does browser.runtime.sendMessage() return a promise but we have also started developing a convenience wrapper around it (see ​js/api.js).

[saroyanm]

Replying to greiner:

Is this ticket still relevant or can we close it?

Because we've already started adopting promises in various places. Plus, not only does browser.runtime.sendMessage() return a promise but we have also started developing a convenience wrapper around it (see ​js/api.js).

I agree, this ticket is already irrelevant.