Opened on 09/21/2017 at 09:02:12 AM

Closed on 10/11/2019 at 02:29:14 AM

#5746 closed defect (rejected)

Notification not shown in Edge

Reported by: Ross Assignee:
Priority: Unknown Milestone:
Module: Platform Keywords: closed-in-favor-of-gitlab
Cc: sebastian, oleksandr, geo Blocked By:
Blocking: Platform: Edge
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Environment

ABP 0.9.11.1849
Edge 40 / Windows 10

How to reproduce

  1. Setup Fiddler (or other proxy) to intercept requests from Edge.
  2. Setup Fiddler/proxy to respond to notification.adblockplus.org/notification.json with the test json below.
  3. Install ABP Edge build.
  4. Wait for notification request from extension.

Observed behaviour

Edge receives the notification but appears to do nothing with it.

Expected behaviour

The same notification.json sent to ABP Chrome (with target as adblockpluschrome) shows a "Test" notification as expected.

Example json

{ \"notifications\": [ { \"targets\": [{ \"extension\": \"adblockplusedge\" }], \"id\": \"1\", \"message\": { \"en-US\": \"Test\" }, \"severity\": \"normal\", \"title\": { \"en-US\": \"Test\" } } ], \"version\": \"201707281538\" }

Attachments (0)

Change History (5)

comment:1 Changed on 09/21/2017 at 09:07:58 AM by Ross

To get Fiddler to respond add the following to OnBeforeResponse in Rules > Customize Rules:

if( oSession.PathAndQuery.Contains("notification.json"))
{

var res = "escapedjsonstringhere";
oSession.utilSetResponseBody(res);

}

comment:2 Changed on 03/09/2019 at 12:54:08 AM by sebastian

  • Cc geo added

Also see #7347.

Last edited on 03/09/2019 at 12:54:53 AM by sebastian

comment:3 Changed on 05/24/2019 at 07:43:36 PM by geo

I'm not sure what the original issue was, but currently, the notifications API is still broken on Edge, so only popup notifications will be displayed.

One thing, for the default type, the title and message are missing on Edge.

comment:4 Changed on 10/10/2019 at 11:00:01 AM by greiner

  • Component changed from Unknown to Platform

comment:5 Changed on 10/11/2019 at 02:29:14 AM by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
 
Note: See TracTickets for help on using tickets.