Opened on 09/22/2017 at 11:42:35 AM
Closed on 10/10/2017 at 01:01:19 PM
#5752 closed change (fixed)
Remove the "safari" build target from buildtools
| Reported by: | tlucas | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | kzar, sebastian, kvas, fhd | Blocked By: | |
| Blocking: | #5757 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
The safari branch in adblockpluschrome is no longer actively maintained. Given the significant differences to other browsers extension implementations, including major limitations, and the comparable low numbers of Adblock Plus for Safari users on macOS, it is no longer worth it.
We might still release infrequent minor updates of Adblock Plus for Safari, but there would be no need to update the buildtools dependency for these releases. The long-term plan is to eventually port Adblock Plus for iOS, to macOS, which will then replace the traditional browser extension for Safari.
Moreover, since jsHydra integration has been removed (#4552), newer versions of buildtools can no longer build Adblock Plus for Safari, anymore, anyway.
What to change
Remove the buildtools' features for safari extensions:
- Remove packagerSafari.py, xarfile.py
- Remove the safari types and targets from build.py
- Remove safariInfo.js.tmpl and Info.plist.tmpl from templates
- Remove the safari target from releaseAutomation.py
Attachments (0)
Change History (10)
comment:2 Changed on 09/22/2017 at 09:55:01 PM by sebastian
- Description modified (diff)
comment:3 Changed on 09/22/2017 at 10:03:23 PM by sebastian
- Summary changed from Remove safari features from the buildtools to Remove the "safari" build target from buildtools
comment:4 Changed on 09/23/2017 at 08:36:28 AM by tlucas
- Blocked By 5758 added
comment:5 Changed on 09/23/2017 at 07:41:52 PM by sebastian
- Blocked By 5758 removed
comment:6 Changed on 09/23/2017 at 07:53:51 PM by sebastian
- Blocking 5757 added
comment:7 Changed on 09/23/2017 at 07:54:00 PM by sebastian
- Priority changed from Unknown to P3
- Ready set
comment:8 Changed on 10/02/2017 at 10:40:20 AM by tlucas
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:9 Changed on 10/10/2017 at 12:55:49 PM by abpbot
A commit referencing this issue has landed:
Issue 5752 - Removing safari support
comment:10 Changed on 10/10/2017 at 01:01:19 PM by tlucas
- Resolution set to fixed
- Status changed from reviewing to closed
Note that sitescripts imports packagerSafari and xarfile in order to extract metadata for the development builds. While we can keep using an old version of buildtools for building the Safari extension, sitescripts must remain compatible with the latest buildtools.
While in low maintenance mode, (unlike for legacy Gecko extensions, see ticket:5751#comment:4) we occasionally still have to release updates of Adblock Plus for Safari until we eventually discontinued/replaced it. Therefore I'm afraid we cannot abandon the development builds yet.
Still there are good reasons to already remove the Safari packager from buildtools. So I suggest to just move the related logic into sitescripts, for the time being.