Opened on 09/22/2017 at 11:18:11 AM
Closed on 10/10/2017 at 12:54:09 PM
Last modified on 10/26/2017 at 11:23:09 AM
#5751 closed change (fixed)
Remove the "gecko" build target from buildtools
| Reported by: | tlucas | Assignee: | tlucas |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | kzar, sebastian, kvas, fhd, trev | Blocked By: | |
| Blocking: | #5757, #5836, #5837, #5845 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by tlucas)
Background
Starting with Firefox 57, legacy Gecko extensions are no longer supported. Therefore future versions of Adblock Plus will be WebExtensions, the development build has already been switched over to the gecko-webext build. If necessary we can still release emergency updates for the legacy Gecko extension, after support has been removed from buildtools, as we wouldn't update the dependency anyway in this case.
What to change
Remove the buildtools' features for legacy gecko extensions:
- Remove packagerGecko.py
- Remove the gecko types and target from build.py
- Remove support for gecko-style translations from localeTools.py
- Remove the folder lib
- Remove install.rdf.tmpl and bootstrap.js.tmpl from templates
- Remove the gecko target from releaseAutomation.py
Integration notes
Please make sure that every dependent module adheres to the loss of support for .dtd translations.
Attachments (1)
Change History (27)
comment:1 Changed on 09/22/2017 at 11:34:10 AM by tlucas
- Cc fhd added
comment:2 Changed on 09/22/2017 at 11:37:33 AM by kzar
- Cc trev added
comment:4 follow-up: ↓ 9 Changed on 09/22/2017 at 08:27:09 PM by sebastian
- Description modified (diff)
- Summary changed from Remove gecko features from the buildtools to Remove the "gecko" build target from buildtools
comment:5 Changed on 09/23/2017 at 07:53:19 AM by tlucas
@sebastian : yes, i have been discussing with vasily how he wanted this to be done (regarding this issue and #5752)
comment:6 Changed on 09/23/2017 at 08:20:03 AM by tlucas
- Blocked By 5757 added
comment:7 Changed on 09/23/2017 at 08:26:10 AM by tlucas
@sebastian, @kvas - i would appreciate a hint on where to look for code related to the other gecko extensions mentioned in ticket:5751#comment:4 - i was only able to find related code in web.adblockplus.org (download links)
comment:8 Changed on 09/23/2017 at 09:42:26 AM by kzar
- Blocking 5080 added
comment:9 in reply to: ↑ 4 Changed on 09/23/2017 at 06:09:17 PM by trev
Replying to sebastian:
@trev: Can you remove those extensions from the sitescripts.ini on the server?
Not before Firefox 57 is out.
Note that this isn't a blocker as long as the dependency in sitescripts repository isn't updated.
comment:10 Changed on 09/23/2017 at 06:28:39 PM by sebastian
- Blocking 5535 added; 5080 removed
comment:11 Changed on 09/23/2017 at 07:52:54 PM by sebastian
- Blocked By 5757 removed
- Blocking 5757 added
- Priority changed from Unknown to P3
- Ready set
Until recently the server running sitescripts, always used the latest buildtools. However, since this is no longer true, we need a dependency update anyway, and can just defer it until Firefox 57 is out. Though, I'm not sure how useful development builds for our less popular legacy extensions are, after we already abandoned the developments builds for the legacy Gecko extension of Adblock Plus. Anyway, I updated #5757 accordingly, which as a result is no longer blocking this issue.
comment:12 Changed on 09/24/2017 at 09:38:24 AM by kzar
- Blocking 5535 removed
(Since we've given up automatically generating the resolve paths for now this is no longer blocking #5535.)
comment:13 Changed on 09/25/2017 at 09:01:42 AM by tlucas
- Owner set to tlucas
comment:14 Changed on 09/25/2017 at 11:18:46 AM by tlucas
- Description modified (diff)
Changed on 09/25/2017 at 11:19:18 AM by tlucas
comment:15 Changed on 09/28/2017 at 10:02:34 AM by tlucas
- Blocking 5763 added
comment:16 Changed on 09/29/2017 at 09:02:40 AM by kzar
comment:17 Changed on 10/02/2017 at 10:39:50 AM by tlucas
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:18 Changed on 10/02/2017 at 11:59:28 AM by tlucas
- Description modified (diff)
comment:19 Changed on 10/02/2017 at 11:59:52 AM by tlucas
- Description modified (diff)
comment:20 Changed on 10/05/2017 at 07:42:32 PM by sebastian
- Blocking 5836 added
comment:21 Changed on 10/05/2017 at 08:23:27 PM by sebastian
- Blocking 5837 added
comment:22 Changed on 10/09/2017 at 02:27:25 AM by sebastian
- Blocking 5845 added
comment:23 Changed on 10/09/2017 at 07:12:18 PM by sebastian
- Blocking 5763 removed
comment:24 Changed on 10/10/2017 at 12:52:32 PM by abpbot
A commit referencing this issue has landed:
Issue 5751 - Removing legacy gecko support
comment:25 Changed on 10/10/2017 at 12:54:09 PM by tlucas
- Resolution set to fixed
- Status changed from reviewing to closed
comment:26 Changed on 10/26/2017 at 11:23:09 AM by tlucas
This change introduced a regression, see #5939
Note that sitescripts still imports packagerGecko in order to extract metadata for development builds of legacy Gecko extensions. While the development builds of Adblock Plus have been switched to WebExtensions, we still have following legacy extensions:
Those will stop working with Firefox >=57 as well, and we won't update them anymore either. So we can just remove their development builds, along with the related code in sitescripts. This, however, needs to happen before support for legacy Gecko extension is removed from buildtools.
@trev: Can you remove those extensions from the sitescripts.ini on the server?
@tlucas: Can you file a separate issue and remove the related code from sitescripts, first?