Opened on 09/24/2017 at 09:35:07 AM
Closed on 01/05/2018 at 03:37:19 PM
Last modified on 03/20/2018 at 01:12:17 PM
#5762 closed change (fixed)
Use relative require paths in adblockpluscore
| Reported by: | kzar | Assignee: | hfiguiere |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | sebastian, fhd, sergz | Blocked By: | #5535 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
Previously we've used our own system for managing modules, the files bundled were specified manually in the metadata and then modules were required with no path part.
With the switch to using webpack for bundling, bundled files are resolved at build time automatically. When modules are required with no path part webpack will check the hard-coded resolve paths for suitable files, but that has several limitations / problems.
What to change
Change all require calls in adblockpluscore to use relative paths. E.g.
In adblockpluscore/lib/elemHide.js this require:
const {ElemHideException} = require("filterClasses");
should become:
const {ElemHideException} = require("./filterClasses");
Attachments (0)
Change History (9)
comment:1 Changed on 09/25/2017 at 11:14:57 AM by trev
- Priority changed from Unknown to P3
- Ready set
comment:2 Changed on 09/26/2017 at 01:15:43 PM by hfiguiere
- Owner set to hfiguiere
comment:3 Changed on 09/26/2017 at 01:29:59 PM by hfiguiere
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 12/21/2017 at 11:29:03 AM by fhd
- Cc trev removed
comment:5 Changed on 01/04/2018 at 02:19:44 PM by kzar
- Blocked By 6230 added
comment:6 Changed on 01/05/2018 at 02:28:18 PM by abpbot
comment:7 Changed on 01/05/2018 at 03:34:56 PM by kzar
- Blocked By 6230 removed
comment:8 Changed on 01/05/2018 at 03:37:19 PM by kzar
- Cc sergz added
- Resolution set to fixed
- Status changed from reviewing to closed
comment:9 Changed on 03/20/2018 at 01:12:17 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Doesn't seem to have caused any major breakages.
ABP 3.0.2.1983
Firefox 51 / 58 / Windows 10
Chrome 49 / 65 / Windows 7
Opera 36 / 51 / Windows 7
A commit referencing this issue has landed:
Issue 5762 - Use relative require paths