Opened on 09/25/2017 at 06:04:38 AM

Closed on 10/06/2017 at 05:22:05 PM

#5763 closed defect (fixed)

Target languages supported by Firefox

Reported by: sebastian Assignee: sebastian
Priority: P2 Milestone:
Module: Automation Keywords:
Cc: tlucas, oleksandr Blocked By: #5777
Blocking: #5836, #5837 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29561557

Description (last modified by sebastian)

Background

The build targets chrome, gecko-webext and edge only include translations for languages supported by Chrome. There are plenty of languages supported by Firefox that aren't included in that subset.

Moreover, Firefox and Microsoft Edge differentiate between es-MX (Mexico), es-AR (Argentinia) and es-CL (Chile), while Chrome combines these dialects of Spanish under es-419. But since Firefox and Microsoft Edge don't recognize es-419, they instead fall back to es (i.e. Spanish as spoken in Spain).

What to change

  • Add missing target languages, supported by Firefox, to the translation project on Crowdin.
  • Update langMappingChrome accordingly to account for the new languages, removing unnecessary region suffixes for languages we only translate one dialect of.
  • Remove the mapping for es-419 from langMappingChrome, so that es-MX is imported/exported unchanged. But instead convert it to es-419 only when building for the chrome target.

Attachments (0)

Change History (9)

comment:1 Changed on 09/25/2017 at 12:03:31 PM by tlucas

  • Owner set to tlucas

comment:2 Changed on 09/25/2017 at 05:08:49 PM by tlucas

  • Blocked By 5777 added

comment:3 Changed on 09/25/2017 at 07:54:05 PM by sebastian

  • Cc oleksandr added
  • Description modified (diff)
  • Summary changed from Firefox webext builds don't pickup Latin American Spanish translations. to Firefox and Microsoft Edge don't pickup Latin American Spanish translations

comment:4 Changed on 10/01/2017 at 05:10:43 PM by sebastian

  • Description modified (diff)
  • Owner changed from tlucas to sebastian
  • Summary changed from Firefox and Microsoft Edge don't pickup Latin American Spanish translations to Target languages supported by Firefox

comment:5 Changed on 10/01/2017 at 05:12:42 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed on 10/05/2017 at 07:42:32 PM by sebastian

  • Blocking 5836 added

comment:7 Changed on 10/05/2017 at 08:23:27 PM by sebastian

  • Blocking 5837 added

comment:8 Changed on 10/06/2017 at 05:21:42 PM by abpbot

A commit referencing this issue has landed:
Issue 5763 - Target languages supported by Firefox

comment:9 Changed on 10/06/2017 at 05:22:05 PM by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
 
Note: See TracTickets for help on using tickets.