Opened on 09/26/2017 at 10:55:39 AM

Closed on 10/02/2017 at 02:13:02 PM

#5789 closed defect (fixed)

Warning - 'stringByAddingPercentEscapesUsingEncoding:' is deprecated.

Reported by: CraftyDeano Assignee: CraftyDeano
Priority: Unknown Milestone:
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: ashephard, dzhang Blocked By:
Blocking: Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​​https://codereview.adblockplus.org/29556618/

Description

Building currently generates the following warning:

AdblockPlusSafari/NSString+AdblockPlus.m:43:24: 'stringByAddingPercentEscapesUsingEncoding:' is deprecated: first deprecated in iOS 9.0 - Use -stringByAddingPercentEncodingWithAllowedCharacters: instead, which always uses the recommended UTF-8 encoding, and which encodes for a specific URL component or subcomponent since each URL component or subcomponent has different rules for what characters are valid.

Will migrate away from the deprecated API to its successor.

Attachments (0)

Change History (2)

comment:1 Changed on 09/27/2017 at 02:23:20 PM by CraftyDeano

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 10/02/2017 at 02:13:02 PM by CraftyDeano

  • Resolution set to fixed
  • Status changed from reviewing to closed

​Landed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from CraftyDeano.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.