Opened on 09/26/2017 at 11:20:01 AM

Closed on 10/03/2017 at 06:48:22 AM

#5790 closed change (fixed)

Get ready for integration into Chromium

Reported by: asmirnov Assignee:
Priority: P3 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29556626

Description

Background

We're working on integrating libadblockplus/libadblockplus-android into Chromium. For this some changes should be done. Related to #5643 as it's a part of integration.

What to change

add methods to get Filter Engine C++ ptr, modify helper to be able to distinguish allocating/releasing of engines.

Attachments (0)

Change History (3)

comment:1 Changed on 09/26/2017 at 11:30:15 AM by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 10/03/2017 at 06:47:48 AM by abpbot

A commit referencing this issue has landed:
​Issue 5790 - Get ready for integration into Chromium

comment:3 Changed on 10/03/2017 at 06:48:22 AM by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.