Opened on 09/26/2017 at 01:12:50 PM

Closed on 10/02/2017 at 02:13:29 PM

#5791 closed defect (fixed)

Analysis Issue - User-facing text should use localised strings

Reported by: CraftyDeano Assignee: CraftyDeano
Priority: Unknown Milestone:
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: ashephard, dzhang Blocked By:
Blocking: Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29556813/

Description

Xcode static analyser highlights the following issues:

Assertion: User-facing text should use localized string macro
File: adblockplussafariios/AdblockPlusSafari/AdblockPlusController.m:229

Assertion: User-facing text should use localized string macro
File: adblockplussafariios/AdblockPlusSafari/AdblockPlusContainerController.m:97

Assertion: User-facing text should use localized string macro
File: adblockplussafariios/AdblockPlusSafari/RootController.m:165

Assertion: User-facing text should use localized string macro
File: adblockplussafariios/AdblockPlusSafari/CustomFilterListsController.m:284

Assertion: User-facing text should use localized string macro
File: adblockplussafariios/AdblockPlusSafari/CustomFilterListsController.m:288

The strings referenced should be replaced for a localised strings.

Attachments (0)

Change History (3)

comment:1 Changed on 09/26/2017 at 01:49:02 PM by CraftyDeano

  • Owner set to CraftyDeano

comment:2 Changed on 09/27/2017 at 01:04:52 AM by CraftyDeano

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 10/02/2017 at 02:13:29 PM by CraftyDeano

  • Resolution set to fixed
  • Status changed from reviewing to closed

​Landed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from CraftyDeano.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.