Opened on 09/26/2017 at 01:21:09 PM

Closed on 10/02/2017 at 02:13:49 PM

#5792 closed defect (fixed)

Analysis Issue - Potential null dereference

Reported by: CraftyDeano Assignee: CraftyDeano
Priority: Unknown Milestone:
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: ashephard, dzhang Blocked By:
Blocking: Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29556769

Description (last modified by CraftyDeano)

Xcode static analyser highlights the following issues:

Assertion: Potential null dereference.  According to coding standards in 'Creating and Returning NSError Objects' the parameter may be null
File: adblockplussafariios/AdblockPlusSafari/AdblockPlus+ActivityChecking.m:69

Assertion: Potential null dereference.  According to coding standards in 'Creating and Returning NSError Objects' the parameter may be null
File: adblockplussafariios/AdblockPlusSafari/AdblockPlus+ActivityChecking.m:63

Add checks to error to ensure its not NULL as per ​Apples Documentation.

Attachments (0)

Change History (3)

comment:1 Changed on 09/26/2017 at 01:49:06 PM by CraftyDeano

  • Owner set to CraftyDeano

comment:2 Changed on 09/26/2017 at 10:29:49 PM by CraftyDeano

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 10/02/2017 at 02:13:49 PM by CraftyDeano

  • Resolution set to fixed
  • Status changed from reviewing to closed

​Landed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from CraftyDeano.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.