Opened on 09/28/2017 at 12:46:30 PM
Closed on 10/05/2017 at 04:40:38 PM
Last modified on 10/23/2017 at 01:40:57 PM
#5805 closed change (fixed)
Add standalone suffix to the apk name of multi-locale builds
Reported by: | diegocarloslima | Assignee: | diegocarloslima |
---|---|---|---|
Priority: | P4 | Milestone: | Adblock-Browser-for-Android-1.3.0 |
Module: | Adblock-Browser-for-Android | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Platform: | Adblock Browser for Android | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | yes |
Review URL(s): |
Description
Background
Currently, we have 3 parameters in our configuration file that defines which variant of ABB will be built in a multi-locale build: ARCHITECTURE, DISTRIBUTION_MODE and BUILD_MODE. Currently, we can only know which ARCHITECTURE and BUILD_MODE were selected based on the generated .apk name. There's currently no way to tell which DISTRIBUTION_MODE (standalone or store) was selected based on the generated .apk name.
What to change
Add a -standalone suffix to the generated .apk name if the DISTRIBUTION_MODE is standalone. The omission of that suffix will indicate that the DISTRIBUTION_MODE is store.
Attachments (0)
Change History (6)
comment:1 Changed on 09/29/2017 at 07:04:06 PM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 10/05/2017 at 03:54:25 PM by abpbot
comment:3 Changed on 10/05/2017 at 04:40:38 PM by diegocarloslima
- Milestone set to Adblock-Browser-for-Android-1.3.0
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 10/05/2017 at 06:02:18 PM by diegocarloslima
This issue can be verified by building the project with DISTRIBUTION_MODE = "standalone" configuration. I have successfully built the project and the standalone suffix was appended to the .apk name:
14:48:32 INFO - ##### 14:48:32 INFO - ##### MultiLocaleBuild summary: 14:48:32 INFO - ##### 14:48:32 INFO - Added locale zh-TW successfully. 14:48:32 INFO - Added locale pa-IN successfully. 14:48:32 INFO - Added locale gd successfully. 14:48:32 INFO - Added locale gn successfully. 14:48:32 INFO - Added locale gl successfully. 14:48:32 INFO - Added locale en-GB successfully. 14:48:32 INFO - Added locale lo successfully. 14:48:32 INFO - Added locale tr successfully. 14:48:32 INFO - Added locale lv successfully. 14:48:32 INFO - Added locale lt successfully. 14:48:32 INFO - Added locale th successfully. 14:48:32 INFO - Added locale te successfully. 14:48:32 INFO - Added locale ta successfully. 14:48:32 INFO - Added locale bn-IN successfully. 14:48:32 INFO - Added locale de successfully. 14:48:32 INFO - Added locale da successfully. 14:48:32 INFO - Added locale pt-BR successfully. 14:48:32 INFO - Added locale nb-NO successfully. 14:48:32 INFO - Added locale gu-IN successfully. 14:48:32 INFO - Added locale ga-IE successfully. 14:48:32 INFO - Added locale es-CL successfully. 14:48:32 INFO - Added locale trs successfully. 14:48:32 INFO - Added locale el successfully. 14:48:32 INFO - Added locale eo successfully. 14:48:32 INFO - Added locale eu successfully. 14:48:32 INFO - Added locale sv-SE successfully. 14:48:32 INFO - Added locale ru successfully. 14:48:32 INFO - Added locale rm successfully. 14:48:32 INFO - Added locale ro successfully. 14:48:32 INFO - Added locale dsb successfully. 14:48:32 INFO - Added locale hsb successfully. 14:48:32 INFO - Added locale bg successfully. 14:48:32 INFO - Added locale ms successfully. 14:48:32 INFO - Added locale ast successfully. 14:48:32 INFO - Added locale wo successfully. 14:48:32 INFO - Added locale br successfully. 14:48:32 INFO - Added locale ja successfully. 14:48:32 INFO - Added locale pt-PT successfully. 14:48:32 INFO - Added locale es-AR successfully. 14:48:32 INFO - Added locale nn-NO successfully. 14:48:32 INFO - Added locale fy-NL successfully. 14:48:32 INFO - Added locale or successfully. 14:48:32 INFO - Added locale xh successfully. 14:48:32 INFO - Added locale ca successfully. 14:48:32 INFO - Added locale son successfully. 14:48:32 INFO - Added locale cy successfully. 14:48:32 INFO - Added locale cs successfully. 14:48:32 INFO - Added locale hi-IN successfully. 14:48:32 INFO - Added locale pl successfully. 14:48:32 INFO - Added locale hr successfully. 14:48:32 INFO - Added locale hu successfully. 14:48:32 INFO - Added locale he successfully. 14:48:32 INFO - Added locale uz successfully. 14:48:32 INFO - Added locale ml successfully. 14:48:32 INFO - Added locale ur successfully. 14:48:32 INFO - Added locale cak successfully. 14:48:32 INFO - Added locale zh-CN successfully. 14:48:32 INFO - Added locale en-ZA successfully. 14:48:32 INFO - Added locale uk successfully. 14:48:32 INFO - Added locale mr successfully. 14:48:32 INFO - Added locale my successfully. 14:48:32 INFO - Added locale is successfully. 14:48:32 INFO - Added locale it successfully. 14:48:32 INFO - Added locale an successfully. 14:48:32 INFO - Added locale as successfully. 14:48:32 INFO - Added locale ar successfully. 14:48:32 INFO - Added locale bn-BD successfully. 14:48:32 INFO - Added locale et successfully. 14:48:32 INFO - Added locale az successfully. 14:48:32 INFO - Added locale es-ES successfully. 14:48:32 INFO - Added locale id successfully. 14:48:32 INFO - Added locale sr successfully. 14:48:32 INFO - Added locale nl successfully. 14:48:32 INFO - Added locale kab successfully. 14:48:32 INFO - Added locale fr successfully. 14:48:32 INFO - Added locale fa successfully. 14:48:32 INFO - Added locale ff successfully. 14:48:32 INFO - Added locale mai successfully. 14:48:32 INFO - Added locale fi successfully. 14:48:32 INFO - Added locale ka successfully. 14:48:32 INFO - Added locale kk successfully. 14:48:32 INFO - Added locale hy-AM successfully. 14:48:32 INFO - Added locale sq successfully. 14:48:32 INFO - Added locale ko successfully. 14:48:32 INFO - Added locale kn successfully. 14:48:32 INFO - Added locale es-MX successfully. 14:48:32 INFO - Added locale sk successfully. 14:48:32 INFO - Added locale sl successfully. 14:48:32 INFO - Copying logs to upload dir... /Users/dlima/Workspace/adblockbrowser-build/adblockbrowser/obj-arm-linux-androideabi/dist/adblockbrowser-1.2.0-20171005135710-arm-standalone.apk
comment:5 Changed on 10/11/2017 at 10:31:33 PM by traynard
@diegocarloslima - is there any testing instructions for me? or is this strictly a build time issue?
comment:6 Changed on 10/23/2017 at 01:40:57 PM by traynard
- Verified working set
Confirmed with Diego that this is a build issue
A commit referencing this issue has landed:
Issue 5805 - Add standalone suffix to the apk name of multi-locale builds