Opened on 09/28/2017 at 04:03:31 PM

Closed on 09/28/2017 at 05:29:14 PM

#5806 closed defect (fixed)

Acceptable ads being added to the UI on load

Reported by: saroyanm Assignee: saroyanm
Priority: P1 Milestone:
Module: User-Interface Keywords:
Cc: greiner Blocked By:
Blocking: #5158 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29558637/

Description

Environment

Any browser

How to reproduce

  1. Run ./test_server.py from inside the adblockplusui repository.
  2. Load [​https://hg.adblockplus.org/adblockplusui/file/tip/background.js#l154 Privacy frinedly AA ads], instead of Acceptable Ads
  3. Go to ​​http://localhost:5000/new-options.html
  4. Observe

Observed behaviour

Acceptable Ads is being selected

Expected behaviour

Privacy Friendly Acceptable Ads is selected

NOTE

We are adding Acceptable Ads to the view, seems like this is leftover from old-new options page implementation where we always had Acceptable Ads in the UI.

Attachments (0)

Change History (5)

comment:1 Changed on 09/28/2017 at 04:31:28 PM by saroyanm

  • Review URL(s) modified (diff)

comment:2 Changed on 09/28/2017 at 04:31:38 PM by saroyanm

  • Owner set to saroyanm

comment:3 Changed on 09/28/2017 at 04:31:45 PM by saroyanm

  • Status changed from new to reviewing

comment:4 Changed on 09/28/2017 at 05:28:33 PM by abpbot

A commit referencing this issue has landed:
​Issue 5806 - fixed Acceptable Ads misbehavior in UI

comment:5 Changed on 09/28/2017 at 05:29:14 PM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.