Opened on 10/03/2017 at 08:04:17 AM

Closed on 10/11/2017 at 05:06:51 PM

#5823 closed change (fixed)

Change header content based on page on help.eyeo.com

Reported by: ire Assignee: ire
Priority: P3 Milestone: help.eyeo.com 1.0.0
Module: Websites Keywords:
Cc: wspee, juliandoucette Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29563558

Description

Background

The header on help.eyeo.com is dependent on if the current page is related to a product or not. The current header assumes that the current page is related to Adblock Plus always.

What to change

Change the header according to the ​Specification

Attachments (0)

Change History (3)

comment:1 Changed on 10/03/2017 at 08:07:24 AM by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 10/11/2017 at 05:06:18 PM by abpbot

A commit referencing this issue has landed:
​Issue 5823 - Change header content based on page on help.eyeo.com

comment:3 Changed on 10/11/2017 at 05:06:51 PM by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ire.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.