Opened on 10/04/2017 at 08:05:14 AM

Closed on 10/16/2017 at 05:42:50 PM

#5824 closed change (fixed)

Refactor CustomSelect on help.eyeo.com

Reported by: ire Assignee: ire
Priority: Unknown Milestone: help.eyeo.com 1.0.0
Module: Websites Keywords:
Cc: juliandoucette, wspee Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29564555/

Description

Background

  • We added a language selector to help.eyeo.com
  • We are extending this custom select element to be used as a dropdown for the browser selector (see ​codereview)
  • The custom select functionality needs to be more extendable

What to change

Refactor CustomSelect

Attachments (0)

Change History (3)

comment:1 Changed on 10/04/2017 at 08:07:51 AM by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 10/10/2017 at 11:55:30 AM by abpbot

A commit referencing this issue has landed:
​Issue 5824 - Refactor CustomSelect on help.eyeo.com

comment:3 Changed on 10/16/2017 at 05:42:50 PM by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ire.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.