Opened on 10/04/2017 at 03:32:52 PM

Closed on 01/09/2019 at 10:40:15 PM

#5828 closed defect (fixed)

[CMS] Additional paths require `settings.ini`

Reported by: kvas Assignee: rhowell
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By: #5336
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29972568/

Description

Environment

Linux or MacOS, CMS with additional paths feature from #5336. The source of any website.

How to reproduce

  1. Add an additional path to the website via additional-paths key in [paths] section of settings.ini. The additional path directory should not contain settings.ini.
  2. Run a test server or generation for the website.

Observed behaviour

The CMS throws an IOError for settings.ini in the additional path.

Expected behaviour

The files contained within the directory of additional path can be used even if there's no settings.ini in it.

Attachments (0)

Change History (6)

comment:1 Changed on 10/04/2017 at 03:40:57 PM by juliandoucette

LGTM

comment:2 Changed on 10/24/2017 at 10:40:52 AM by kvas

  • Priority changed from Unknown to P3
  • Ready set
  • Summary changed from Additional paths require `settings.ini` to [CMS] Additional paths require `settings.ini`

comment:3 Changed on 05/14/2018 at 11:02:33 AM by rhowell

  • Owner set to rhowell

comment:4 Changed on 01/03/2019 at 11:44:02 PM by rhowell

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 01/09/2019 at 10:36:37 PM by abpbot

A commit referencing this issue has landed:
Issue 5828 - Additional paths require settings.ini

comment:6 Changed on 01/09/2019 at 10:40:15 PM by rhowell

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from rhowell.
 
Note: See TracTickets for help on using tickets.