Opened on 10/04/2017 at 04:14:07 PM

Closed on 10/06/2017 at 10:25:22 AM

Last modified on 11/13/2017 at 01:59:14 PM

#5829 closed change (fixed)

Remove flag icons from adblockplus.org

Reported by: juliandoucette Assignee:
Priority: P3 Milestone: adblockplus.org 1.1.0
Module: Websites Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29564699

Description (last modified by juliandoucette)

Background

See adblockplus.org 2.x.

The new abp.org design contains locale codes in the language selector and does not suffix language only links.

What to change

Remove flags from existing HTML/CSS.

Notes

Flags are not languages ​[1]

Generally, a locale is made up of a language and a location. e.g. English (United States).

Attachments (0)

Change History (5)

comment:1 Changed on 10/04/2017 at 04:18:46 PM by juliandoucette

  • Description modified (diff)

comment:2 Changed on 10/04/2017 at 04:18:58 PM by juliandoucette

  • Review URL(s) modified (diff)

comment:3 Changed on 10/06/2017 at 10:25:22 AM by juliandoucette

  • Resolution set to fixed
  • Status changed from new to closed

Landed ​https://bitbucket.org/adblockplus/adblockplus.org/commits/b45287c321fc225ead3b89713d692969cb7613b2

comment:4 Changed on 10/23/2017 at 08:26:57 PM by juliandoucette

  • Description modified (diff)

comment:5 Changed on 11/13/2017 at 01:59:14 PM by abpbot

A commit referencing this issue has landed:
​Issue 5829 - Removed flags from adblockplus.org

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.