Opened on 10/05/2017 at 08:36:54 AM

Closed on 10/05/2017 at 12:23:04 PM

Last modified on 12/22/2017 at 12:31:30 PM

#5831 closed change (fixed)

Update default strings

Reported by: asmirnov Assignee:
Priority: P3 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: vicky Blocked By:
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29565555/

Description

Background

We're going to translate default strings (in English) to required languages.
During this Lisa found that default strings should be corrected (http://hub.eyeo.com/issues/4082#change-14104).

What to change

Replace the strings with correct ones from attached libadblockplus-android-settings-strings_UPDATED.xlsx.

Attachments (2)

device-2017-10-05-151200.png (108.8 KB) - added by asmirnov on 10/05/2017 at 10:13:19 AM.
after changes
device-2017-10-05-151232.png (81.0 KB) - added by asmirnov on 10/05/2017 at 10:13:41 AM.
after changes (dialog)

Download all attachments as: .zip

Change History (7)

comment:1 Changed on 10/05/2017 at 08:40:19 AM by asmirnov

  • Cc vicky added

comment:2 Changed on 10/05/2017 at 08:43:51 AM by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

Changed on 10/05/2017 at 10:13:19 AM by asmirnov

after changes

Changed on 10/05/2017 at 10:13:41 AM by asmirnov

after changes (dialog)

comment:3 Changed on 10/05/2017 at 12:22:37 PM by abpbot

A commit referencing this issue has landed:
Issue 5831 - Update default strings

comment:4 Changed on 10/05/2017 at 12:23:04 PM by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 12/22/2017 at 12:31:30 PM by abpbot

A commit referencing this issue has landed:
Issue 5831 - Update default strings

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
 
Note: See TracTickets for help on using tickets.