Opened on 10/05/2017 at 12:10:43 PM
Closed on 10/05/2017 at 03:16:09 PM
#5832 closed defect (fixed)
Exceptions being thrown in popup page
| Reported by: | kzar | Assignee: | mjethani |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-3.0-for-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, greiner, mjethani | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Environment
Chrome 61, Linux, devbuild of adblockpluschrome from 585646051e9c.
How to reproduce
- Open a new tab, browse to some website E.g. https://reddit.com
- Right click on the ABP icon.
- Click "Inspect pop-up"
- Press refresh in your tab.
Observed behaviour
Exceptions are displayed in the console:
Error in event handler for runtime.onMessage: TypeError: Cannot read property 'id' of undefined
at ext.PageMap.set (chrome-extension://ghggfhepnjpmpghomanfhkljmbalkebe/ext/background.js:46:26)
at port.on (chrome-extension://ghggfhepnjpmpghomanfhkljmbalkebe/lib/adblockplus.js:378:14)
at Port._onMessage (chrome-extension://ghggfhepnjpmpghomanfhkljmbalkebe/lib/adblockplus.js:1120:22)
at ext._EventTarget._dispatch (chrome-extension://ghggfhepnjpmpghomanfhkljmbalkebe/ext/common.js:48:22)
at chrome.runtime.onMessage.addListener (chrome-extension://ghggfhepnjpmpghomanfhkljmbalkebe/ext/content.js:14:26)
Expected behaviour
No exceptions are displayed.
Notes
- This appears to be a regression caused by the commit 30e3ff8f07f3 (see #5593).
Attachments (0)
Change History (6)
comment:1 Changed on 10/05/2017 at 12:16:36 PM by mjethani
- Owner set to mjethani
comment:2 Changed on 10/05/2017 at 01:42:00 PM by mjethani
comment:4 Changed on 10/05/2017 at 02:38:39 PM by kzar
- Priority changed from Unknown to P2
- Ready set
- Status changed from new to reviewing
comment:5 Changed on 10/05/2017 at 03:14:06 PM by abpbot
A commit referencing this issue has landed:
Issue 5832 - Use runtime.onMessage directly in popup
comment:6 Changed on 10/05/2017 at 03:16:09 PM by mjethani
- Milestone set to Adblock-Plus-for-Chrome-Opera-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
The culprit is ext/content.js, which was included in popup.html recently. There's no need to include it as such, we can use the browser APIs directly, so I'm removing it.