Opened on 10/20/2017 at 10:53:16 AM

Closed on 10/24/2017 at 02:10:54 PM

#5896 closed change (fixed)

Simplify error handling in the issue reporter

Reported by: trev Assignee: trev
Priority: Unknown Milestone:
Module: User-Interface Keywords:
Cc: greiner Blocked By:
Blocking: #5883 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29587629/

Description

Background

When #5880 was implemented, we had to expect the case where a promise would be rejected with a plain object. This has been addressed in an additional commit in #4579 now so that rejection reason is always an Error instance.

What to change

Drop the unnecessary if (!e.name && e.message) block in issue reporter's initDataCollector() function.

Attachments (0)

Change History (4)

comment:1 Changed on 10/24/2017 at 12:13:52 PM by trev

  • Owner set to trev

comment:2 Changed on 10/24/2017 at 12:14:11 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 10/24/2017 at 02:07:29 PM by abpbot

A commit referencing this issue has landed:
​Issue 5896 - Simplify error handling in the issue reporter

comment:4 Changed on 10/24/2017 at 02:10:54 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.