Opened on 10/25/2017 at 10:28:48 AM
Closed on 11/30/2017 at 03:53:16 PM
Last modified on 01/23/2018 at 10:54:17 AM
#5931 closed change (fixed)
Create tests for util package
| Reported by: | jwangenheim | Assignee: | jwangenheim |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-for-Samsung-Browser-1.1.3 |
| Module: | Adblock-Plus-for-Samsung-Browser | Keywords: | |
| Cc: | diegocarloslima | Blocked By: | |
| Blocking: | Platform: | Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
In order to control code quality it's better to have tests that run after every commit.
What to change
We need to add tests for the util package, meaning testing the classes PreferenceUtils, SharedPrefsUtils and SubscriptionUtils.
Attachments (0)
Change History (5)
comment:1 Changed on 10/25/2017 at 01:37:24 PM by jwangenheim
- Owner set to jwangenheim
comment:2 Changed on 11/14/2017 at 03:24:49 PM by jwangenheim
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 11/30/2017 at 03:52:24 PM by abpbot
comment:4 Changed on 11/30/2017 at 03:53:16 PM by jwangenheim
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 01/23/2018 at 10:54:17 AM by mario
- Milestone set to Adblock-Plus-for-Samsung-Browser-1.1.3
Adjusted milestone of unassigned, closed issues of ABP/SI
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5931 - Create tests for util package