Opened on 10/25/2017 at 07:54:02 AM
Closed on 11/02/2017 at 10:02:23 AM
Last modified on 12/22/2017 at 12:31:32 PM
#5930 closed change (fixed)
Turn off "MissingTranslation" lint warnings
| Reported by: | asmirnov | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Libadblockplus-Android | Keywords: | |
| Cc: | Blocked By: | #5902 | |
| Blocking: | Platform: | Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
In task #5902 we've added translations for settings UI. However while building WebViewApp (https://github.com/adblockplus/libadblockplus-android/tree/master/libadblockplus-android-webviewapp) we can get warnings/errors as some strings are not translated. Actually it was done intentionally as some strings are internal and should not be translated (eg. https://github.com/adblockplus/libadblockplus-android/blob/master/libadblockplus-android-settings/res/values/adblock_settings_strings_internal.xml). Also some strings in WebView app are not required to be translated as it's just an example of library usage so it does not affect any 3rd-party app using libadblockplus-android.
What to change
Disable "MissingTranslation" warning/error for the files that should not be translated.
Attachments (0)
Change History (4)
comment:1 Changed on 10/25/2017 at 07:59:50 AM by asmirnov
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 11/02/2017 at 10:01:35 AM by abpbot
comment:3 Changed on 11/02/2017 at 10:02:23 AM by asmirnov
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 12/22/2017 at 12:31:32 PM by abpbot
A commit referencing this issue has landed:
Issue 5930 - Turn off "MissingTranslation" lint warnings
A commit referencing this issue has landed:
Issue 5930 - Turn off "MissingTranslation" lint warnings