Opened on 10/26/2017 at 11:19:28 AM

Closed on 10/26/2017 at 01:20:00 PM

#5939 closed defect (fixed)

Crowdin downloads suffixed translations to the wrong folder

Reported by: tlucas Assignee: tlucas
Priority: P2 Milestone:
Module: Automation Keywords:
Cc: kzar, sebastian, trev, Shikitita Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29589613/

Description (last modified by kzar)

Environment

Debian 9 (Stretch)
Python 2.7.13
​adblockpluschrome repository at ​current HEAD 108b7b0e3c66.

How to reproduce

  1. Change the basename in metadata.chrome to this-is-very-much-a-test-proje
  2. Download translations from crowdin, which contain locales with a suffix ( e.g. zh-TW )

If there are no locales with a suffix, you can add them to the Crowdin project:

(adblockpluschrome)$ python build.py -t chrome setuptrans API_KEY

Modify the translations on the crowdin website and build and download the translations:

(adblockpluschrome)$ python build.py -t chrome gettranslations API_KEY
  1. Look at the downloaded / created folders in the folder _locales

Observed behaviour

The translations for zh-TW are downloaded into the folder _locales/zh-TW.

Expected behaviour

The translations for zh-TW are downloaded into the folder _locales/zh_TW.

Note

This regression was introduced by #5751.

Attachments (0)

Change History (8)

comment:1 Changed on 10/26/2017 at 11:21:39 AM by tlucas

  • Description modified (diff)

comment:2 Changed on 10/26/2017 at 11:40:46 AM by tlucas

  • Description modified (diff)
  • Sensitive set

comment:3 Changed on 10/26/2017 at 11:51:57 AM by kzar

  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set

comment:4 Changed on 10/26/2017 at 11:55:48 AM by tlucas

  • Sensitive unset

comment:5 Changed on 10/26/2017 at 11:57:44 AM by tlucas

  • Owner set to tlucas

comment:6 Changed on 10/26/2017 at 11:59:07 AM by tlucas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed on 10/26/2017 at 01:18:46 PM by abpbot

A commit referencing this issue has landed:
​Issue 5939 - Download translations to correct folder

comment:8 Changed on 10/26/2017 at 01:20:00 PM by tlucas

  • Cc Shikitita added
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from tlucas.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.