Rename "libadblockplus-android"

[asmirnov]

Background

For historical reason and to be consistent with other eyeo products libadblockplus-android is named the way it is at the moment. However this seems to be confusing for Android developers (according to Felix at android dev meeting) and should be improved.

What to change

Rename libadblockplus-android to something more common to Android developers.

[asmirnov]

Usually it's named as "Product X Android SDK", see:

• "Dropbox Android SDK" (​https://www.dropbox.com/developers-v1/core/sdks/android, ​https://github.com/dropbox/dropbox-sdk-java)
• "Fillr Android SDK" (​http://fillr.github.io/docs/sdk/browser/android/)
• "Spotify Android SDK" (​https://github.com/spotify/android-sdk)
• "Foursquare SDK for Android" (​https://github.com/jiramot/foursquare-android-sdk)

[asmirnov]

Android guys, what's your suggestion? I's name it "Adblock Plus Android SDK"

[jwangenheim]

I think 'Adblock Plus Android SDK' would be a good choice . The only alternative I could imagine would be something like "Adblock WebView" but

1. We offer more than only a WebView that blocks ads and probably we want to extend the functionality in the future
2. It makes more sense to have the product name reflected in the name of the lib.

[asmirnov]

Replying to jwangenheim:

I think 'Adblock Plus Android SDK' would be a good choice . The only alternative I could imagine would be something like "Adblock WebView" but

1. We offer more than only a WebView that blocks ads and probably we want to extend the functionality in the future

BTW AdblockWebView is not the only module provided and the users can use 'libadblockplus-android' submodule without 'libadblockplus-android-webview' used.

2. It makes more sense to have the product name reflected in the name of the lib.

[jwangenheim]

Yeah, that's exactly what I meant by 1. :) I just could image Adblock-Webview as a name for the lib, becuse it's probably the most striking and easy to implement feature.

[sergz]

I like Adblock Plus Android SDK.

In order to handle WebView I would like to firstly know what will be changed when the product is renamed. In particular if the everything continues to live in the same repo libadblockplus-android then we can have proper names for each component, one has to just figure out how to properly work with them, namely, build, distribute and convey, etc. E.g. take a look at spotify, they have SDK consisting from several libraries and it's shortly explain in ​The SDK's structure section.

[fhd]

I think we can leave out the _Plus_, we did the same for Adblock Browser and AdblockWebView. As in Adblock Android SDK.

[diegocarloslima]

I would suggest the full name for README /docs to be Adblock SDK for Android and the contracted version for ids / repo name to be Adblock-SDK-Android

[jwangenheim]

Hey guys,

should we make a final decision here? I like 'Adblock Android SDK' as a name for the whole repository. But I think it would also make sense to distribute libadblockplus-android, libadblockplus-android-settings and libadblockplus-android-webview as single maven dependencies, to make adblocking in Android apps available as fast and easy as possible.

[asmirnov]

it would also make sense to distribute libadblockplus-android, libadblockplus-android-settings and libadblockplus-android-webview as single maven dependencies

I don't think it's good idea, i see no point in making it single module at all. Using of 'libadblockplus-android' does not mean using 'libadblockplus-android-webview', similar to settings - they are independent of WebView (see ​https://github.com/adblockplus/libadblockplus-android/blob/master/libadblockplus-android-settings/pom.xml).

What about module dependencies i prefer leave everything as-is, but just rename the modules.

[abpbot]

A commit referencing this issue has landed:
​Issue 6000 - Rename "libadblockplus-android"