Opened on 01/23/2018 at 07:09:47 AM
Closed on 01/24/2018 at 01:20:35 PM
#6300 closed change (fixed)
Remove Maven and Ant support
| Reported by: | asmirnov | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Libadblockplus-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #5139, #6000 | Platform: | Android |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
We still support Maven and Ant as build tools (see pom.xml and build.xml).
They are deprecated nowadays and Android projects use Gradle.
Ant support has been removed from latest Android SDKs (see #5139).
However it's preferred to have AARs pushed in local maven repo after built by Gradle.
What to change
Remove Maven and Ant support, push AARS to local maven repo.
Attachments (0)
Change History (7)
comment:1 Changed on 01/23/2018 at 07:42:03 AM by asmirnov
comment:2 Changed on 01/23/2018 at 07:48:39 AM by asmirnov
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 01/23/2018 at 09:30:46 AM by asmirnov
publishing to maven repo: https://docs.gradle.org/current/userguide/publishing_maven.html
comment:4 Changed on 01/24/2018 at 06:08:01 AM by asmirnov
- Blocking 6000 added
comment:5 Changed on 01/24/2018 at 06:09:07 AM by asmirnov
Discussed it with Diego.
According to #6205 we're going to publish artifacts in bintray (or any other external Maven repository).
So no push to local Maven repo is required.
comment:6 Changed on 01/24/2018 at 01:19:30 PM by abpbot
Some commits referencing this issue have landed:
comment:7 Changed on 01/24/2018 at 01:20:35 PM by asmirnov
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
Since we have lot's of build variants (ARCH x BuildType) = 3 x 2 = 6 which ones should we push to maven repository?
Let's say it's debug build for ARM. Should we push AAR to repo? Should we push only 'abi_all' + Release only?
Also we have to add Maven module dependencies properly and it seems to be not trivial task as we have to map Gradle modules to Maven modules.