Opened on 11/08/2017 at 04:39:00 PM
Closed on 02/21/2018 at 04:19:18 PM
Last modified on 04/04/2018 at 07:23:35 PM
#6008 closed change (duplicate)
Add trigger to open Updates page
| Reported by: | greiner | Assignee: | greiner |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, kzar, wspee, martin, saroyanm | Blocked By: | #5943, #6336, #6341 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://codereview.adblockplus.org/29664623/ |
||
Description (last modified by greiner)
Background
In #5943 we added a static page for outlining various changes that have been added in the latest version of Adblock Plus. Now we need to show it whenever someone updates to that particular version.
What to change
- Update the adblockplusui dependency to 2a04df826943 to include the new update page
- Update metadata.chrome to add a mapping for the page and required files so they're included in the build.
- Show the update page according to the spec:
This page should open once, in a new tab, the first time the user starts the extension after he upgraded to the earliest version that contains the new options page. It should not be shown on any subsequent update.
- Reuse suppress_first_run_page preference to not show updates page if it's set
Hints for testers
When installing the extension:
- Show first-run page (except if suppress_first_run_page=true)
- Don't show updates page
When updating the extension for the first time:
- Don't show first-run page
- Show updates page (except if suppress_first_run_page=true)
When updating the extension for the second time:
- Don't show first-run page
- Don't show updates page
Attachments (0)
Change History (15)
comment:1 Changed on 11/08/2017 at 04:40:03 PM by greiner
- Cc wspee martin added
comment:3 Changed on 11/14/2017 at 06:54:23 PM by greiner
- Owner set to greiner
comment:4 Changed on 11/22/2017 at 02:48:06 PM by saroyanm
- Cc saroyanm added
comment:5 Changed on 11/28/2017 at 05:43:12 PM by greiner
comment:6 Changed on 01/12/2018 at 04:34:03 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 01/15/2018 at 12:36:49 PM by greiner
- Description modified (diff)
Reflected previous comment in ticket description and added hints for testers.
comment:8 Changed on 01/18/2018 at 11:46:12 AM by greiner
- Description modified (diff)
Added list of UI changes included in dependency update
comment:10 Changed on 01/29/2018 at 12:15:45 PM by greiner
- Blocked By 6336 added
comment:11 Changed on 01/31/2018 at 11:29:04 AM by greiner
- Blocked By 6341 added
comment:12 Changed on 01/31/2018 at 11:47:13 AM by abpbot
A commit referencing this issue has landed:
Issue 6008 - Expose updates version via lib/prefs.js
comment:13 Changed on 01/31/2018 at 11:57:13 AM by greiner
- Description modified (diff)
Updated information for dependency update.
comment:14 Changed on 02/21/2018 at 04:19:18 PM by greiner
- Resolution set to duplicate
- Status changed from reviewing to closed
Closing this ticket in favor of #6403 since adding the updates page trigger is no longer the only change that's required for the dependency update.
Therefore let's continue the ongoing code review over there.
comment:15 Changed on 04/04/2018 at 07:23:35 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Suppress first run page preference and updates page behave as described.
Chrome 65 / Ubuntu 16.04
FYI: I've suggested considering the suppress_first_run_page preference when deciding whether or not to show the Updates page so please let me know if you have any objections.