Opened on 11/24/2017 at 10:11:19 AM
Closed on 01/09/2018 at 01:23:23 PM
Last modified on 03/27/2018 at 12:52:42 PM
#6089 closed defect (fixed)
SVG checkbox icon rendering issue
| Reported by: | saroyanm | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | greiner, wspee, jeen | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by saroyanm)
Environment
Chrome V62
Firefox V57
How to reproduce
- Download adblockplusui repository and run the test server
- Open Desktop options page
- Observe
Observed behaviour
The SVG Icons are rendered incorrectly in comparison to Firefox V56:
- Acceptable Ads selected checkbox, has no round border (See attachment)
Expected behaviour
Rendered SVG icons in Chrome and Firefox look similar
Attachments (4)
Change History (15)
Changed on 11/24/2017 at 10:11:47 AM by saroyanm
Changed on 11/24/2017 at 10:11:54 AM by saroyanm
Changed on 11/24/2017 at 10:11:59 AM by saroyanm
Changed on 11/24/2017 at 10:13:40 AM by saroyanm
comment:2 Changed on 11/24/2017 at 10:14:32 AM by saroyanm
- Cc greiner wspee jeen added
- Component changed from Unknown to User-Interface
- Description modified (diff)
- Priority changed from Unknown to P2
- Ready set
comment:3 Changed on 11/29/2017 at 07:54:30 PM by saroyanm
comment:4 Changed on 11/30/2017 at 10:18:15 AM by saroyanm
- Owner set to saroyanm
comment:5 Changed on 12/01/2017 at 06:46:44 PM by saroyanm
#6115 should fix Tooltip icon has borders cut off, Acceptable Ads default checkbox, has repetitive background, depending on how fast the review will go for that issue I'll provide separate patch for this issue if needed.
comment:6 Changed on 01/08/2018 at 03:11:08 PM by saroyanm
- Description modified (diff)
- Priority changed from P2 to P3
While the other two issues are already fixed, I'll remove them from this issue.
The other one is minor so I'll decrease the priority, I anyway have a straight forward patch ready.
comment:7 Changed on 01/08/2018 at 03:12:04 PM by saroyanm
- Description modified (diff)
- Summary changed from SVG icons rendering issues in chrome to SVG checkbox icon rendering issue
comment:8 Changed on 01/08/2018 at 03:14:47 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:9 Changed on 01/09/2018 at 01:22:39 PM by abpbot
A commit referencing this issue has landed:
Issue 6089 - Adjusted checkbox cut borders
comment:10 Changed on 01/09/2018 at 01:23:23 PM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
comment:11 Changed on 03/27/2018 at 12:52:42 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed.
ABP 3.0.2.1998
Firefox 51 / 58 / Windows 10
Chrome 49 / 65 / Windows 7
Opera 36 / 51 / Windows 7
I've created a reduced test case for tooltip issue and filed a Chromium bug -> https://bugs.chromium.org/p/chromium/issues/detail?id=789650