Opened on 11/09/2017 at 11:38:56 AM
Closed on 08/29/2019 at 05:48:47 PM
#6016 closed defect (rejected)
Multiple "block element" windows are permitted (chrome / firefox)
| Reported by: | mapx | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Platform | Keywords: | closed-in-favor-of-gitlab |
| Cc: | sebastian, kzar, mjethani, jeen, athornburgh | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by mapx)
Environment
windows 7
ABP last build (1913)
chrome / firefox
How to reproduce
- go to google.com or any other site
- click ABP icon, click block element=> the normal window is opened (empty but this is another bug - is empty in chrome too ...)
- click on page, refresh the page, repeat the above steps (block element and so on)
Observed behaviour
- multiple add filter(s) windows are opened (the old one is not closed as a new block element was requested)
Expected behaviour
- only 1 add filter(s) window should be permitted
Attachments (0)
Change History (10)
comment:1 Changed on 11/09/2017 at 11:39:20 AM by mapx
- Summary changed from Multiple "block element" are permitted (chrome / firefox) to Multiple "block element" windows are permitted (chrome / firefox)
comment:2 Changed on 11/09/2017 at 12:30:39 PM by trev
comment:4 Changed on 11/09/2017 at 12:36:57 PM by mapx
right, I added above: refresh the page => the old window will still be opened and a new one will be opened
comment:5 Changed on 11/09/2017 at 12:38:54 PM by mapx
Probably it should be avoided having more "Block element" windows (even if for different websites)
comment:6 Changed on 11/10/2017 at 02:59:31 PM by kzar
- Cc jeen athornburgh added
Probably it should be avoided having more "Block element" windows (even if for different websites)
That's a question for the product team, what do you think? If you have two tabs open you could open the "block element" popup for both, is that desirable or should the first "block element" popup close when the second is opened?
comment:7 Changed on 11/10/2017 at 03:05:08 PM by mapx
Well, in practice it's very difficult to have such a situation, but I see uBo is permitting working in 2 different sites, so probably "we" can permit it.
The other situation instead (2 or more windows for the same site) is clearly an issue.
comment:8 Changed on 11/10/2017 at 03:33:32 PM by jeen
I would suggest only allowing one pop-up and bringing that pop-window to the front.
I would avoid having separate windows for each site because our popup window behaves very differently to uBlock - where the popup menu stays fixed to the individual pages.
comment:9 Changed on 12/21/2017 at 11:26:28 AM by fhd
- Cc trev removed
comment:10 Changed on 08/29/2019 at 05:48:47 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.
At least on Linux this behavior is not reproducible, I can only open multiple "Block element" windows for different websites. Within the same website clicking the icon again indicates that blocking an element is already in progress and offers to cancel that.