Update subscriptions.xml

[jwangenheim]

Background

The subscriptions the user can select are parsed from subscriptions.xml file. We need to update the file to the latest version and make sure that the format of the xml can be handled by the parser.

What to change

Update subscriptions.xml to the latest version

Hint for tesers

This can be tested by checking whether the list of available filter lists is the same as in our official ​subscription.xml

Please make sure to also test for data migration:

• If the removed filter lists aren't subscribed to, they're supposed to be removed from the subscription list in ABP.
• If the removed filter lists are subscribed to, they're supposed to stay in the subscription list in ABP and marked as active.

[jwangenheim]

I checked the latest version of adblockpluscore:chrome/content/ui/subscriptions.xml and compared it to the version we currently use in ABP for Samsung internet. The two lists have a different structure, it looks like we use an old format in ABP for Samsung internet:

<--- Currently used in ABP for Samsung Internet --->

<subscription title="Bulgarian list (български)" homepage="http://stanev.org/abp/" type="ads" prefixes="bg">
    <variants>
      <variant title="Bulgarian list+EasyList" url="https://easylist-downloads.adblockplus.org/bulgarian_list+easylist.txt" complete="true"/>
      <variant title="Bulgarian list" url="http://stanev.org/abp/adblock_bg.txt"/>
    </variants>
</subscription>

<--- Latest version in adblockpluscore --->

<subscription title="Bulgarian list+EasyList"
                specialization="български"
                url="https://easylist-downloads.adblockplus.org/bulgarian_list+easylist.txt"
                homepage="http://stanev.org/abp/"
                prefixes="bg"
                author="Александър Станев"
                type="ads"/>

The latest version in core also only contains subscriptions of type "ads". If we would start using this list, we loose all 4 lists of type "other" (Anti-Adblocker-Blocker, Tracking, Social Media, Malware Domains).

So before we decide how to keep subscriptions.xml up to date, we need to adjust the code in ABP for Samsung Internet in order to work with the new structure.

@fhd @rene
Whats your opinion on that?

[jwangenheim]

For the automatic updates I created a separate ticket in GitLab: ​https://gitlab.com/eyeo/adblockplus/adblockplussbrowser/issues/4