Opened on 11/09/2017 at 03:48:30 PM
Closed on 11/10/2017 at 09:35:10 AM
Last modified on 11/30/2017 at 01:31:54 PM
#6020 closed defect (fixed)
Unnecessary code being included in webpack bundles
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | trev, sebastian, tlucas, sylvaing@spoluck.ca | Blocked By: | |
| Blocking: | #6022 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by trev)
Environment
adblockpluschrome ecdd8caaf81a
How to reproduce
- Open the Chrome developer tools for the background page
- Click the Sources pane and expand the webpack:// section
Observed behaviour
The unused (webpack)/buildin/global.js is listed.
Expected behaviour
That file should not be listed, since we don't use it!
Notes
The code in question uses eval which is flagged by Mozilla's add-on linter. It is never being used and wouldn't work anyway because of CSP.
Attachments (0)
Change History (11)
comment:1 Changed on 11/09/2017 at 03:51:36 PM by kzar
- Cc awagner@mozilla.com kewisch@mozilla.com removed
- Summary changed from Unnesissary code being included in webpack bundles to Unnecessary code being included in webpack bundles
comment:2 Changed on 11/09/2017 at 04:10:16 PM by tlucas
- Ready set
comment:4 Changed on 11/09/2017 at 04:55:48 PM by kzar
comment:5 Changed on 11/09/2017 at 05:13:40 PM by kzar
It's this check in adblockpluscore/lib/rusha.js which is causing it: typeof global !== 'undefined' && global.Buffer && global.Buffer.isBuffer(data)
comment:6 Changed on 11/09/2017 at 05:14:36 PM by kzar
- Component changed from Build-and-Release-Tools to Core
comment:7 Changed on 11/09/2017 at 05:56:06 PM by kzar
- Component changed from Core to Build-and-Release-Tools
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:8 Changed on 11/10/2017 at 09:22:47 AM by abpbot
A commit referencing this issue has landed:
Issue 6020 - Avoid including (webpack)/buildin/global.js in bundles
comment:9 Changed on 11/10/2017 at 09:30:56 AM by kzar
- Blocking 6022 added
comment:10 Changed on 11/10/2017 at 09:35:10 AM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
comment:11 Changed on 11/30/2017 at 01:31:54 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Files/code no longer present in webpack:// section.
ABP 3.0.1.1939
Chrome 62 / Windows 10
According to https://webpack.github.io/analyse it's being included due to a "cjs require" in adblockpluscore/lib/rusha.js.