Opened on 11/10/2017 at 09:09:57 AM
Closed on 11/20/2017 at 11:36:32 AM
#6021 closed change (fixed)
Refactor build.py to use modern argparse
| Reported by: | tlucas | Assignee: | tlucas |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | trev, Sebastian | Blocked By: | |
| Blocking: | #5996 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by tlucas)
Background
The buildtools' build.py was implemented before a standard means of parsing command line arguments was introduced into the Python Standard Library. This has changed
What to change
- Get rid of the custom argument parser in build.py
- Keep all help texts and present them appropriately for every available command
- Group commands by command, rather than by (previously) extension type
Integration Notes
The release checklist templates for Chrome/Opera/Safari and Firefox need to be adjusted to contain the new correct commands.
Other repositories must adhere to the new interface of buildtools.build:
old:
buildtools.build.processArgs(BASE_DIR, sys.argv)
new:
buildtools.build.process_args(BASE_DIR)
Hints for testers
This should have no impact on the builds themselves at all.
Attachments (0)
Change History (10)
comment:2 Changed on 11/13/2017 at 02:48:38 PM by tlucas
- Cc trev Sebastian added
comment:3 Changed on 11/13/2017 at 02:49:02 PM by tlucas
comment:4 Changed on 11/13/2017 at 02:50:38 PM by tlucas
- Blocking 5996 added
comment:5 Changed on 11/14/2017 at 05:38:40 PM by tlucas
- Priority changed from Unknown to P3
- Ready set
comment:6 Changed on 11/14/2017 at 05:38:47 PM by tlucas
- Owner set to tlucas
comment:7 Changed on 11/15/2017 at 10:26:43 AM by tlucas
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:9 Changed on 11/20/2017 at 11:36:13 AM by abpbot
A commit referencing this issue has landed:
Issue 6021 - Refactoring build.py
comment:10 Changed on 11/20/2017 at 11:36:32 AM by tlucas
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
I decided to actually create an issue for this, since their will be some integration work.