Opened on 11/13/2017 at 05:30:11 PM

Closed on 11/22/2017 at 12:03:58 PM

Last modified on 06/06/2019 at 12:59:37 PM

#6031 closed change (fixed)

Implement Acceptable Ads notification

Reported by: saroyanm Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: greiner, wspee Blocked By: #6042
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29609587/

Description (last modified by saroyanm)

Background

In order to inform the users about the conflict of EasyPrivacy and Acceptable Ads both being enabled at the same time, we need to show the user descriptive notification.

What to change

Implement Acceptable Ads notification as specified here.

Attachments (0)

Change History (7)

comment:1 Changed on 11/13/2017 at 05:30:33 PM by saroyanm

  • Description modified (diff)

comment:2 Changed on 11/14/2017 at 12:00:18 PM by saroyanm

  • Owner set to saroyanm

comment:3 Changed on 11/15/2017 at 05:12:42 PM by saroyanm

  • Blocked By 6042 added

comment:4 Changed on 11/15/2017 at 05:13:13 PM by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 11/22/2017 at 10:41:14 AM by abpbot

A commit referencing this issue has landed:
Issue 6031 - Implement Acceptable Ads notification

comment:6 Changed on 11/22/2017 at 12:03:58 PM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed on 11/29/2017 at 08:34:49 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Works as expected.

ABP 3.0.1.1939
Firefox 51 / 57 / Windows 7
Chrome 62 / Windows 7

Last edited on 12/03/2017 at 02:29:45 PM by Ross

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
 
Note: See TracTickets for help on using tickets.