Introduce ui_warn_tracking boolean preference and updated adbockplusui dependency to #bb9b1b67aedf9

[saroyanm]

Background

If a user has both EasyPrivacy and Acceptable Ads enable at the same time it's important we explain the inherent conflict between those lists to them (#6031). Whitelisting filters take precendence over blacklisting ones, and so the user might be subject to some tracking that way.

Once the user has seen the explanation we need a way to remember not to keep displaying it, which will be the ui_warn_tracking preference.

What to change

Add ui_warn_tracking to the ​preferences, make it default to true:

/**
 * Whether to show tracking warning in options page when both Acceptable Ads and subscription of type "Privacy" are enabled
 * @type {boolean}
 */
defaults.ui_warn_tracking = true;

And update adblockplusui dependency to bb9b1b67aedf9 in order to include the changes below:

• #5872 - Style changes
• #5990 - Chrome broken icons fix
• #6031 - Acceptable Ads Notification

Hint for testers

• The icons should not misbehave anymore for Chrome
  • Hovering Trash/Close/Gear icons should change the color
  • Toggle icon in the advanced tab filter lists table should change it state when clicked
  • Acceptable Ads checkbox should change the state on click
• Acceptable Ads notification should behave as following
  • When Acceptable Ads and Block additional tracking are both selected show the notification
  • When user click on X or OK, got it button, this notification shouldn't be shown anymore.

Note: The styles are slightly different, but that's just a cosmetic change, to reflect new colors and styles.

[greiner]

@saroyanm The JSDoc type says that this is a boolean but the default value you specify in the ticket description is a string. Based on the implementation in #6031 the default value should be changed to true.

[saroyanm]

Replying to greiner:

@saroyanm The JSDoc type says that this is a boolean but the default value you specify in the ticket description is a string. Based on the implementation in #6031 the default value should be changed to true.

Thanks for noticing, was a bad copy-past.
Fixed.

[saroyanm]

@Kzar, @Sebastian: Can you please have a look and mark this as ready if applicable.

I can also provide a patch after that.

[kzar]

Perhaps do the dependency update to include the adblockplusui changes at the same time as a part of this issue?

[saroyanm]

Replying to kzar:

Perhaps do the dependency update to include the adblockplusui changes at the same time as a part of this issue?

Okey, I think the other review should be ready soon as well.

[saroyanm]

Changed notification to warning in the description, as we reference to this as a warning currently.

[saroyanm]

I updated the description in order more properly describe the usage, as it's in general for the subscription of type="privacy" we are using/recommending.

[saroyanm]

Updated the description in order to provide hint to the testers and include dependency update as well

[abpbot]

A commit referencing this issue has landed:
​Issue 6042 - Introduced ui_warn_tracking boolean preference and updated adbockplusui dependency to bb9b1b67aedf9

[saroyanm]

Filled an issue, as a regression to this, but it's easy to fix #6074

[Ross]

Done. Works as expected.

ABP 3.0.1.1939
Firefox 51 / 57 / Windows 7
Chrome 52 / 62 / Windows 7
Opera 38 / 49 / Windows 7